Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring validation error output in sync with lineage flattening #150

Closed
sdboyer opened this issue May 15, 2023 · 0 comments · Fixed by #183
Closed

Bring validation error output in sync with lineage flattening #150

sdboyer opened this issue May 15, 2023 · 0 comments · Fixed by #183
Labels
bug Something isn't working prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness

Comments

@sdboyer
Copy link
Contributor

sdboyer commented May 15, 2023 •
edited

I forgot to update thema's validation error wrapping as part of #82. As a result, validation error output now contains output like that seen in #140:

<dashboard@v0.1>._sortedSchemas.1._#schema.gnetId

instead of what it's supposed to be:

<dashboard@v0.1>.gnetId

Fix should be trivial, but maybe best to do it only after we have some actual tests for the validation error wrapper 🤦🏻
@sdboyer sdboyer added the bug Something isn't working label May 15, 2023
@joanlopez joanlopez added prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness labels Jun 11, 2023
@joanlopez joanlopez mentioned this issue Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working prio/mid Medium priority readiness/minimum Requisite for achieving a minimum readiness
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

First pass on refining error messages grafana/thema
2 participants
@sdboyer @joanlopez