-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thema: Flatten schemas to one-dimensional array #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
added
enhancement
New feature or request
breaking change
Breaks existing code
labels
Oct 31, 2022
sdboyer
force-pushed
the
flatten-lineages
branch
from
January 1, 2023 11:41
4bbb709
to
4472009
Compare
sdboyer
force-pushed
the
flatten-lineages
branch
from
January 29, 2023 11:38
4472009
to
5419e38
Compare
sdboyer
force-pushed
the
flatten-lineages
branch
from
January 29, 2023 11:51
5419e38
to
2682ab0
Compare
This was referenced Mar 12, 2023
3 tasks
This is finally, finally good to go. Lots of follow-ups, of course. |
sdboyer
pushed a commit
that referenced
this pull request
May 8, 2023
This is a reversion of a change made in #82. We'll be switching back to to using `any` as soon as possible, but for now it's being pulled out in order to reduce the number of simultaneous changes we need to manage in grafana/grafana.
This was referenced May 8, 2023
This was referenced Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a suggestion from @myitcv at Kubecon last week, the light finally clicked on with how we can get rid of the nested array in
seqs
, add reverse lenses to the structure, and overall just drastically improve UX. In fact, we can get rid of the concept of "sequence" entirely.As an example, the final form for the narrowing exemplar is this:
seqs
is gone, nested arrays are gone.version
is an explicit field within the#SchemaDef
(though there's still no actual choice to be made by the user - it's all governed by backwards compat rules) Additional fields are possible in there, including providing examples of the schema.Lenses are moved into their own, separate structure, independent of the
schemas
list. They're a bit more verbose than i'd like, with it still be necessary to explicitly write theinput
field. Butfrom
andto
are now just a version number, rather than needing to be a reference to the correct schema. Better names for the other fields, too - i thinkresult
is indicative of what's supposed to go there, though i don't think this has reached the level of self-explanatory quite yet.Fixes #2
Fixes #18