Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UnwrapCUE() to Underlying() #70

Closed
sdboyer opened this issue Sep 23, 2022 · 0 comments
Closed

Change UnwrapCUE() to Underlying() #70

sdboyer opened this issue Sep 23, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sdboyer
Copy link
Contributor

sdboyer commented Sep 23, 2022

It doesn't feel like there's an ideal name here, but UnwrapCUE() is using "wrap" in a way that just doesn't feel right.

Also, i don't like staring at CUE all over my code. It's yelly.

Underlying() seems better, and vaguely reminiscent of Go's notion of the type underlying an interface, which at least feels less wrong than Unwrap. Open to suggestions, though. For the limited window before i just do this :)

@IfSentient this change is coming, and it's obviously breaking. It'll be a trivial refactor though, just a method rename.

@sdboyer sdboyer added the good first issue Good for newcomers label Nov 1, 2022
@ishanjainn ishanjainn self-assigned this Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants