Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UnwrapCUE() to Underlying() #88

Merged
merged 3 commits into from
Nov 10, 2022
Merged

Change UnwrapCUE() to Underlying() #88

merged 3 commits into from
Nov 10, 2022

Conversation

ishanjainn
Copy link
Member

This PR refactors UnwrapCUE() to Underlying() as per #70

@sdboyer
Copy link
Contributor

sdboyer commented Nov 8, 2022

Sorry i missed this last week! Could you reroll based on recent changes?

@sdboyer
Copy link
Contributor

sdboyer commented Nov 9, 2022

Looks like a couple failures after the reroll

@CLAassistant
Copy link

CLAassistant commented Nov 9, 2022

CLA assistant check
All committers have signed the CLA.

@ishanjainn
Copy link
Member Author

Looks like a couple failures after the reroll

Yeah my bad, missed the change in lineage.go

@sdboyer
Copy link
Contributor

sdboyer commented Nov 10, 2022

Great, thanks!

@sdboyer sdboyer merged commit c2cee21 into main Nov 10, 2022
mildwonkey pushed a commit that referenced this pull request May 1, 2023
Change `UnwrapCUE()` to `Underlying()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants