Depointerizer types #102
Merged
Depointerizer types #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Jan 20, 2023
encoding/gocode/decorators.go
Outdated
| return nil, false | ||
| } | ||
|
|
||
| func DecoderCompactor() dstutil.ApplyFunc { |
There was a problem hiding this comment.
Let's unexport this, i don't think there's value in exposing it
sdboyer
approved these changes
Jan 22, 2023
|
I'll defer to a follow-up adding test cases to cover these, as we're quite short on time right now and it's not atypical of other things in thema (unfortunately 😭) that they're not tested |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It moves
DecoderCompactorfrom Grafana and createDepointerizerfunction to remove pointers from the types.By default, we are going to remove always the pointers in maps and slices but in the rest of the types will be optional. So the user could decide to remove these pointers or not setting
NoOptionalPointersin the configuration.Related: grafana/grok#1