Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for depointerizer and fixes #105

Merged
merged 2 commits into from
Feb 2, 2023
Merged

Conversation

spinillos
Copy link
Member

@spinillos spinillos commented Jan 30, 2023

Contributes: #103

It adds txtar tests for depointerizer and fixes. I set a map of map[dst.Expr]bool and depointers[s] was always false 馃ぁ.
Because we have only the use cases to depointerize all or only Map/Array types, I change it with a simple bool.

Idk why map is completely ignore in group here.

Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tests! Let's separate the one out per comment then open a follow-up issue

Big question is whether the bug is in cue stdlib openapi gen, or oapi-codegen, or somewhere in between with us

encoding/gocode/testdata/pointers.txtar Outdated Show resolved Hide resolved
Copy link
Contributor

@sdboyer sdboyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@sdboyer sdboyer merged commit e58cc80 into main Feb 2, 2023
@spinillos spinillos deleted the tests-for-depointerizer branch February 3, 2023 09:59
mildwonkey pushed a commit that referenced this pull request May 1, 2023
Add tests for depointerizer and fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants