Do a checkscalar on NumberKind instead of erroring.
#111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`NumberKind` is just `FloatKind | IntKind`. If the scalar field in the Go type is a float, it can hold the value, and we shouldn't error.
|
|
|
Digging into the cue subsume function, we run into this line in case leftKind&NumKind != 0 && rightKind&NumKind != 0:
// n := c.newNum()
return cmpTonode(c, op, c.Num(left, op).X.Cmp(&c.Num(right, op).X)) |
joeblubaugh
commented
Feb 10, 2023
| @@ -27,6 +28,7 @@ seqs: [ | |||
| type TestType struct { | |||
| Astring *string `json:"astring"` | |||
| Anint int64 `json:"anint"` | |||
| Afloat float64 `json:"afloat"` | |||
There was a problem hiding this comment.
Adding this field causes a panic on main, but passes here.
|
i ran into this - basically, So, LGTM, as the test should now catch any potential change in behavior in CUE. thanks! |
mildwonkey
pushed a commit
that referenced
this pull request
May 1, 2023
Do a `checkscalar` on NumberKind instead of erroring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumberKindis justFloatKind | IntKind. If the scalar field in the Go type is a float, it can hold the value, and we shouldn't error.Or at least that's my assertion :-) I don't know what peril this may cause, but it solved a BindType panic that seemed invalid.