Fix missing underscores #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AgnesToulet
approved these changes
Feb 23, 2023
AgnesToulet
reviewed
Feb 23, 2023
Comment on lines
+269
to
+270
| } else if strings.Contains(mx.Name, "_") { | ||
| mx.Name = withoutUnderscore(mx.Name) |
There was a problem hiding this comment.
The issue with these lines is that the fixRawData decorator now fix some underscores (but not all) and the fixUnderscores decorator fix some raw data 😅 I think we should keep them separated.
I was thinking about something like:
iterateArray(a *dst.ArrayType, fn func(i *dst.Ident)) {
...
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found missing underscores inside structs when I upgraded
thema: grafana/grafana#63629.Also I added logic to iterate maps and arrays deeply if we could have these cases.