Lineage: First version of IsAppendOnly #123
Conversation
There was a problem hiding this comment.
i realize this is still marked draft, but it does seem increasingly like we need to get some version of it as a prerequisite to other work.
IMO it's fine to merge this even if the comparison algorithm is flawed, so long as we're happy with the IsAppendOnly function signature.
| return res, nil | ||
| } | ||
|
|
||
| func Equal(val1 cue.Value, val2 cue.Value) bool { |
There was a problem hiding this comment.
Need comment for exported func
| @@ -268,3 +279,23 @@ type unaryConvLineage[T Assignee] struct { | |||
| func (lin *unaryConvLineage[T]) TypedSchema() TypedSchema[T] { | |||
| return lin.tsch | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Need comment for exported func. Probably worth noting in that comment that the comparison algorithm this currently uses is unsophisticated and subject to change
| @@ -268,3 +279,23 @@ type unaryConvLineage[T Assignee] struct { | |||
| func (lin *unaryConvLineage[T]) TypedSchema() TypedSchema[T] { | |||
| return lin.tsch | |||
| } | |||
|
|
|||
| func IsAppendOnly(oldLineage Lineage, newLineage Lineage) bool { | |||
There was a problem hiding this comment.
i think this is the signature we want. Even if we can't convey much in the error message right now, it'll be crucial that a failure here is able to provide line-level feedback on where the problem was.
| func IsAppendOnly(oldLineage Lineage, newLineage Lineage) bool { | |
| func IsAppendOnly(old, new Lineage) error { |
|
Closing in favor of #130 |
This is a first basic implementation of
IsAppendOnly(oldLineage, newLineage Lineage)that does string comparison.Long-term, we probably want a more complex version that is less strict (allow authorized changes).