[bugfix] Fork deepmap/oapi-codegen to fix joinSchema empty interface codegen bug #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only pkg/codegen and pkg/util, which thema's go codegen utilizes, and made changes to pkg/codegen based on the unmerged deepmap/oapi-codegen PR (oapi-codegen/oapi-codegen#717) to fix bug where thema go codegen creates empty interfaces for lineages with joinSchema or any joined (&) CUE values.
|
cc @AgnesToulet |
sdboyer
suggested changes
Apr 13, 2023
There was a problem hiding this comment.
Awesome. Thanks for doing this!
Could you add a internal/deepmap/UPDATING.md file that at least outlines an expected procedure for updating this, if we need to? Nothing big, but in particular it would be good to have a human-readable list of the changes we've made that need to be preserved.
Also, an additional test case within thema's oapi package that captures the fix for #124 would be helpful.
…'d codegen package to the main one. Added a txtar test for joinSchema.
sdboyer
approved these changes
Apr 14, 2023
|
looks excellent, thanks so much for this! |
mildwonkey
pushed a commit
that referenced
this pull request
May 1, 2023
…egen [bugfix] Fork deepmap/oapi-codegen to fix joinSchema empty interface codegen bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forks deepmap/oapi-codegen into
internal/deepmap/oapi-codegen, omitting all packages butpkg/codegenandpkg/util, which are used by thema's go codegen. The fork has been updated with the changes from the PR in oapi-codegen fixing allOf handling, which was the root cause of #124, resulting in any go types generated from joined CUE values ending up as empty interfaces.Resolves #124