thema: Fix Translate() to same version #141

joanlopez · 2023-05-10T10:20:33Z

It fixes the Translate() operation when from and to versions are the same, because the current implementation produces an error in such case:

_objold.steps: conflicting values [...#TranslatedInstance] and {} (mismatched types list and struct):
    ./testdata/internal/schmoo.cue:55:10
    ./translate.cue:37:10
    ./translate.cue:45:10
    ./translate.cue:128:16

It depends on #139

Some open questions inline.

instance_test.go

joanlopez · 2023-05-10T10:24:37Z

instance_test.go

+		for sch := lin.First(); sch != nil; sch = sch.Successor() {
+			for name, ex := range sch.Examples() {
+				for sch := lin.First(); sch != nil; sch = sch.Successor() {
+					// TODO: Validate lacunas


Any thought? Maybe I can just serialize them and write them to the file for the sake of regression.

Agreed, i think that's good

instance_test.go

translate.cue

testdata/internal/basic.cue

testdata/lineage/basic-multiversion.txtar

thema: Fix Translate() to same version

a641c87

joanlopez added the bug Something isn't working label May 10, 2023

joanlopez requested a review from sdboyer May 10, 2023 10:20

joanlopez self-assigned this May 10, 2023