Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thema: Initial pass at Go lenses/migrations #187
thema: Initial pass at Go lenses/migrations #187
Changes from 1 commit
c448b17
1ed2db3
eea4ec7
db0ad40
f330c61
2e7db29
7124f98
5d824ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similarly, reason for not defining this as from, to? This seems backward, I would say "I am going from
a
tob
", not "I am going tob
froma
".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a good one, no. it's all a weird artifact of probably mistakenly trying to be consistent with the expected sort ordering in lenses, where we sort first by
to
and then byfrom
. (That declared sort ordering requirement only applies for CUE lenses, not for these Go things)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for curiosity; Could you give more context about the reasons behind such requirement, please? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring the inputs to be manually sorted by the user was the main way we got away from the need to dynamically sort them in CUE - which was the main source of our performance issues fixed in #173
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant specifically about the order: first by
to
and then byfrom
PS: I guess it's because the heuristics to use that sorted list of lenses is easier this way (first by
to
), but was asking just for curiosity.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahhh - i'm not attached to that as an ordering, either. My motivation was just that, assuming an ascending version sort order (same as with
schemas
), it seemed preferable to have forward lenses precede reverse ones in the list.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I don't see any need (at least for now), to explicitly model every item into its own error, as far as we bring that information back to the consumer.