Replace ast with dst for gocode #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdboyer
suggested changes
Jan 13, 2023
|
This line made me crave some tests that even just minimally verify that output hasn't changed. i realize there are no tests for this right now - totally my fault - but maybe this is a good opportunity to add some. |
|
Basically a txtar-based test like what we have for openapi should do the trick - something that shows outputs of the generator under different parameterizations of inputs |
Co-authored-by: sam boyer <sdboyer@grafana.com>
Co-authored-by: sam boyer <sdboyer@grafana.com>
…nto update-to-dst-for-gocode
sdboyer
approved these changes
Jan 13, 2023
mildwonkey
pushed a commit
that referenced
this pull request
May 1, 2023
Replace ast with dst for gocode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It updates ast with dst for go files.