Throw error if it exists for dashboard variables #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
ryantxu,
a team,
iwysiu and
vickyyyyyyy
and removed request for
a team
vickyyyyyyy
approved these changes
Nov 26, 2021
vickyyyyyyy
reviewed
Nov 26, 2021
src/DataSource.ts
Outdated
| @@ -291,6 +291,9 @@ export class DataSource extends DataSourceWithBackend<TimestreamQuery, Timestrea | |||
| range, | |||
| } as unknown) as DataQueryRequest).pipe( | |||
| map((res) => { | |||
| if (res.error) { | |||
| throw new Error(res.error.message); | |||
There was a problem hiding this comment.
would it be possible for res.error to not have a message? If so, should we handle that case with res.error?.message?
There was a problem hiding this comment.
oops, I meant to check if there is a message, not that we want to throw an error with no message 😄
There was a problem hiding this comment.
by definition yes, message is optional, but in practice don't think so
I wouldn't worry that much about it in this case. We should refactor this component and use a proper QueryEditor here so this code won't be used. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
In the future, we should replace this code and use a custom variable editor.