Quote and join multiple variables #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
ryantxu,
a team,
sarahzinger and
vickyyyyyyy
and removed request for
a team
vickyyyyyyy
approved these changes
Nov 26, 2021
| @@ -55,6 +55,21 @@ export class DataSource extends DataSourceWithBackend<TimestreamQuery, Timestrea | |||
| return query.rawQuery ?? ''; | |||
| } | |||
|
|
|||
| private interpolateVariable = (value: string | string[]) => { | |||
There was a problem hiding this comment.
nice, I'm guessing this is maybe something that can be shared in the sdk or maybe elsewhere if we are reusing this in multiple plugins?
There was a problem hiding this comment.
yes! I have a point in the design document to try to use a common class that cover this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107
As we do in athena, quote and join variables if they have multiple values.