Replace $__interval variable #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
requested review from
a team,
iwysiu and
vickyyyyyyy
and removed request for
a team
fridgepoet
approved these changes
Jan 24, 2022
|
How do I get these changes to work on grafana now? $__interval still isn't working in my query. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100
TIL that the
$__intervalvariable is replaced by default in the frontend when doinginterpolateTemplateVariables. This does not work with alerting so Timestream removes these default template variables to do it in the backend instead. In any case, the$__intervalalias (which is the same than$__interval_ms) was missing.This is something that all the SQL data sources should do so I added an issue for this: grafana/grafana-aws-sdk#44