Always apply double quotes to database and table name #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code coverage report for PR #155
|
andresmgot
reviewed
Mar 25, 2022
fridgepoet
requested review from
iwysiu and
kevinwcyu
and removed request for
a team
andresmgot
reviewed
Mar 25, 2022
fridgepoet
commented
Mar 25, 2022
fridgepoet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Providing names via the UI (i.e. config editor page) saves the names with
"double quotes.In some recent refactoring, we no longer add double quotes when providing names directly from a provisioning file.
This PR checks if the name is already double quoted (for example provided from UI) and if not adds in the quotes (for example provided from provisioning file).
Fixes #153