Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code coverage flow #175

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Update code coverage flow #175

merged 1 commit into from
Jul 18, 2022

Conversation

aangelisc
Copy link
Contributor

No description provided.

@aangelisc aangelisc self-assigned this Jul 18, 2022
@aangelisc aangelisc requested a review from a team as a code owner July 18, 2022 10:04
@aangelisc aangelisc requested review from iwysiu and sarahzinger and removed request for a team July 18, 2022 10:04
@github-actions
Copy link

Backend code coverage report for PR #175
No changes

@github-actions
Copy link

Frontend code coverage report for PR #175
No changes

sarahzinger
sarahzinger approved these changes Jul 18, 2022
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have one for this "common" package too? I'm not terribly familiar with it, maybe it's checked elsewhere?

Is there any way to do this that is less brittle? I could see us adding more folders in the future and forgetting to add them to this list :( It's kind of a bummer pkg doesn't work.

That all said seems like this doesn't hurt us and we can iterate later!

@aangelisc
Copy link
Contributor Author

aangelisc commented Jul 18, 2022 •
edited

should we have one for this "common" package too? I'm not terribly familiar with it, maybe it's checked elsewhere?

Is there any way to do this that is less brittle? I could see us adding more folders in the future and forgetting to add them to this list :( It's kind of a bummer pkg doesn't work.

That all said seems like this doesn't hurt us and we can iterate later!

Completely agree with all this. Will merge this PR and then iterate on the workflow more 😊

EDIT: I've left the common package out as it currently has no tests.

@aangelisc aangelisc merged commit a132a48 into main Jul 18, 2022
@aangelisc aangelisc deleted the code-coverage-update branch July 18, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

Assignees

@aangelisc aangelisc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aangelisc @sarahzinger