Add support for context aware autocompletion #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunker
requested review from
iwysiu and
sarahzinger
and removed request for
a team
|
|
|
Backend code coverage report for PR #188 |
|
Frontend code coverage report for PR #188
|
sarahzinger
approved these changes
Aug 22, 2022
Co-authored-by: Sarah Zinger <sarah.zinger@grafana.com>
iwysiu
reviewed
Aug 22, 2022
iwysiu
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from using the CodeEditor that was used in the query editor, variable editor and annotation editor with the SQL CodeEditor from grafana/experimental. This adds autocompletion including suggestions for macros, functions, keywords, logical operators, comparison operators etc. Like before, timestream uses standard SQL so no specific language components are being passed to the SQL CodeEditor. However, a custom completion item provider is used so that the plugin can resolve tables and columns used by the autocompletion engine.
Please note that the variable editor is now rendering the full QueryEditor, including the left form group with resource selector. This should be fine I think. Please add feedback here if any.
Fixes #126