Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove label action on prs #194

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Remove label action on prs #194

merged 2 commits into from
Sep 21, 2022

Conversation

sarahzinger
Copy link
Member

When external contributors submit prs, this github action fails for them as they do not have our token in their fork of the repo, and it ends up blocking the ci

IMO I'm not sure we really need this action for prs right now. Perhaps in the future we can revisit if there is a better way to go about this.

@sarahzinger sarahzinger requested a review from a team as a code owner September 21, 2022 13:20
@github-actions
Copy link

github-actions bot commented Sep 21, 2022

Backend code coverage report for PR #194

Plugin Main PR Difference
timestream 68.3% 68.3% 0%

@github-actions
Copy link

Frontend code coverage report for PR #194
No changes

@vickyyyyyyy
Copy link
Member

sounds good to me 👍 looks like we also don't run these on PRs for core Grafana: https://github.com/grafana/grafana/blob/main/.github/workflows/commands.yml

@sarahzinger sarahzinger merged commit 4532619 into main Sep 21, 2022
@sarahzinger sarahzinger deleted the remove-label-check-on-prs branch September 21, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants