migrate to create-plugin #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwysiu
commented
Nov 1, 2022
| @@ -18,7 +18,12 @@ describe('DataSource', () => { | |||
| return res; | |||
| }); | |||
| beforeEach(() => { | |||
| jest.spyOn(runtime, 'getTemplateSrv').mockImplementation(() => ({ getVariables: jest.fn(), replace })); | |||
| jest.spyOn(runtime, 'getTemplateSrv').mockImplementation(() => ({ | |||
There was a problem hiding this comment.
updating the outdated packages also required these changes
sarahzinger
reviewed
Nov 4, 2022
package.json
Outdated
| "typescript": "^4.4.0", | ||
| "webpack": "^5.69.1", | ||
| "webpack-cli": "^4.9.2", | ||
| "webpack-livereload-plugin": "^3.0.2" | ||
| }, | ||
| "resolutions": { | ||
| "rxjs": "6.6.3" |
There was a problem hiding this comment.
I think this is throwing errors maybe? Might be worth looking at removing or updating the version?
|
Backend code coverage report for PR #199 |
|
Frontend code coverage report for PR #199
|
sunker
approved these changes
Dec 20, 2022
Co-authored-by: Kevin Yu <kevinwcyu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates from
grafana-toolkittocreate-pluginI had to upgrade the @grafana packages to 9.3.2 in order to get the updated selectors for the e2e tests to pass, which lead to the other code changes.
fixes #197