Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of code-coverage #211

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update version of code-coverage #211

merged 1 commit into from
Nov 30, 2022

Conversation

idastambuk
Copy link
Contributor

Targets code-coverage version of 0.1.13 which uses node 16. This is necessary in order to update @grafana/ dependencies
See grafana/code-coverage#21

@idastambuk idastambuk requested a review from a team as a code owner November 30, 2022 12:53
aangelisc
aangelisc requested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can delete the yarn-error.log file and then merge this 😊

@github-actions
Copy link

Backend code coverage report for PR #211
No changes

@github-actions
Copy link

Frontend code coverage report for PR #211
No changes

@idastambuk
Copy link
Contributor Author

You can delete the yarn-error.log file and then merge this 😊

oops!

aangelisc
aangelisc approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@idastambuk idastambuk merged commit b3ca571 into main Nov 30, 2022
@idastambuk idastambuk deleted the chore/upgrade-code-coverage branch November 30, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridgepoet fridgepoet fridgepoet approved these changes

@aangelisc aangelisc aangelisc approved these changes

@iwysiu iwysiu Awaiting requested review from iwysiu iwysiu is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@idastambuk @fridgepoet @aangelisc