Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase label width to fix overflow. #217

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Increase label width to fix overflow. #217

merged 1 commit into from
Dec 20, 2022

Conversation

chinu-anand
Copy link
Contributor

Fixes #215

@chinu-anand chinu-anand requested a review from a team as a code owner December 18, 2022 07:44
@CLAassistant
Copy link

CLAassistant commented Dec 18, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

kevinwcyu
kevinwcyu approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarahzinger
sarahzinger approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@sarahzinger sarahzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much!

@sarahzinger sarahzinger merged commit 8d343e4 into grafana:main Dec 20, 2022
@idastambuk idastambuk mentioned this pull request Jan 2, 2023
Merged
@idastambuk
Copy link
Contributor

@chinu-anand Hello! I sadly failed submit a comment before this was merged, which this MR implements. I'd really appreciate it if you could check it out and review :) Thanks!

@chinu-anand
Copy link
Contributor Author

@idastambuk nice work. Maintaining consistency is indeed an art of a frontend engineer. 👏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahzinger sarahzinger sarahzinger approved these changes

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@fridgepoet fridgepoet Awaiting requested review from fridgepoet fridgepoet is a code owner automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase label width in query editor
5 participants
@chinu-anand @CLAassistant @idastambuk @sarahzinger @kevinwcyu