Query Editor: Stop running query automatically when all macros are selected #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
changed the title
idastambuk
changed the title
idastambuk
force-pushed
the
fix/runQuery
branch
from
296f2e7
to
74cd520
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR in main grafana introduced the bug where onRunQuery function is getting redefined and therefore triggers the useEffect and an infinite loop (reported here).
The quickest fix is just removing this effect, since we don't want to run query automatically anyway. Furthermore, when the user opens the editor, and selects all the macros, they might not even have anything in the SQL editor, so we don't want to trigger it anyway.
Also fixed another useEffect typo (I think?)
if (!database || !table || !table) {