POC: support paging with streaming queries #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryantxu
commented
Jun 30, 2021
| rawQuery: first.meta?.executedQueryString, | ||
| nextToken: meta.nextToken, | ||
| } as TimestreamQuery; | ||
| // return { |
There was a problem hiding this comment.
This is commented out so we avoid frontend paging in addition to backend paging
ryantxu
commented
Jun 30, 2021
|
|
||
| func (q *openQuery) doStream(ctx context.Context, sender *backend.StreamSender) error { | ||
| backend.Logger.Info("Starting stream for", "queryId", q.queryId, "token", q.query.NextToken) | ||
| timer := time.NewTimer(time.Second * 2) |
There was a problem hiding this comment.
I'm not sure what interval makes the most sense -- since the query will block, something short seems reasonable
|
🤔 hymm -- thinking more about this... I don't think this solves our HA issue, since the initial query may be on a different node than when the client returns to get the streaming updates |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently support paging by having the client submit additional requests over HTTP when a
nextTokenexists -- this PR explores how we could service the requests with a continuous stream from the backend. This uses the new live features in grafana 8TODO?