Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps and jsonnet adjustments #11

Merged
merged 4 commits into from
Aug 11, 2021

Conversation

kgeckhart
Copy link
Contributor

@kgeckhart kgeckhart commented Aug 11, 2021

This is a small set of changes @matthewnolf and I had to make to get things working on our end with k3d. After updating the dependencies and regenerating the lock we were still seeing type errors,

Error: evaluating jsonnet: RUNTIME ERROR: Field does not exist: specType
tns/tanka/environments/default/main.jsonnet:132:14-36
During manifestation
...
Error: evaluating jsonnet: RUNTIME ERROR: Field does not exist: withPort
tns/tanka/vendor/tempo/tempo.libsonnet:68:7-44
During manifestation

The jsonnet changes to default/tempo resolved those errors for everything to come online properly.

The only remaining thing I found but haven't fixed is a 'Panel plugin not found: timeseries' error in the grafana dashboard. Not sure how to go about fixing that one quite yet, perhaps upgrading the version of grafana?

Copy link
Contributor

@malcolmholmes malcolmholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malcolmholmes
Copy link
Contributor

The only remaining thing I found but haven't fixed is a 'Panel plugin not found: timeseries' error in the grafana dashboard. Not sure how to go about fixing that one quite yet, perhaps upgrading the version of grafana?

This could be due to newer versions of Grafana. Does it work if you load it into Grafana 7?

@matthewnolf
Copy link

The only remaining thing I found but haven't fixed is a 'Panel plugin not found: timeseries' error in the grafana dashboard. Not sure how to go about fixing that one quite yet, perhaps upgrading the version of grafana?

This could be due to newer versions of Grafana. Does it work if you load it into Grafana 7?

The Grafana version running is grafana/grafana:7.3.x-exemplars . I think we can update that in a followup to Grafana 8 but not sure it's the cause

@kgeckhart
Copy link
Contributor Author

The only remaining thing I found but haven't fixed is a 'Panel plugin not found: timeseries' error in the grafana dashboard. Not sure how to go about fixing that one quite yet, perhaps upgrading the version of grafana?

This could be due to newer versions of Grafana. Does it work if you load it into Grafana 7?

The Grafana version running is grafana/grafana:7.3.x-exemplars . I think we can update that in a followup to Grafana 8 but not sure it's the cause

Yeah now that it's up and running I'll merge this and maybe make another pass to get some of the apps updated to see what that does.

@kgeckhart kgeckhart merged commit 39b6e2d into main Aug 11, 2021
@kgeckhart kgeckhart deleted the update-deps-and-jsonnet-adjustments branch August 11, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants