Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated README to point to latest k3d release, added tips to doc section #24

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Updated README to point to latest k3d release, added tips to doc section #24

merged 1 commit into from
Feb 1, 2022

Conversation

aldernero
Copy link
Contributor

I went through the demo today and ran into an issue with k3d. The installation instructions for k3d point to an old release, v3.2.0. I installed that version and ran into trouble during cluster creation as one of the k3d command line flags had changed. Initially I thought it was a typo in the create-k3d-cluster script and made a change there, only to run into a more errors from k3d. After installing the latest version, v5.2.2, the create-k3d-cluster script worked without any changes and I could continue with the demo by following the README.

This makes 2 changes to the demo documentation:

  • The link to k3d in the Prerequisites section now points to the latest version.
  • I added a comment in the same section about renaming the downloaded file to k3d and setting execute permissions. This is similar to what is stated in the jsonnet-bundler section.

Copy link
Contributor

@56quarters 56quarters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@gubjanos
Copy link

+1 Already started tracking what is the reason for a flag name change, when I found this issue.

@aldernero aldernero merged commit b1f1379 into grafana:main Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants