Update instructions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ptodev
commented
Oct 20, 2022
install
Outdated
| @@ -30,7 +30,7 @@ fi | |||
| mkdir "$BASEDIR/tanka" && cd "$BASEDIR/tanka" | |||
|
|
|||
| # Initialise Tanka | |||
| tk init --k8s=1.22 | |||
| tk init --k8s=true | |||
There was a problem hiding this comment.
The reason I changed this is that the old command used to throw this error:
Error: invalid argument "1.22" for "--k8s" flag: strconv.ParseBool: parsing "1.22": invalid syntax
Usage:
tk init [flags]
Flags:
-f, --force ignore the working directory not being empty
-h, --help help for init
--k8s set to false to skip installation of k.libsonnet (default true)
Global Flags:
-v, --verbose
Ouch: invalid argument "1.22" for "--k8s" flag: strconv.ParseBool: parsing "1.22": invalid syntax
There was a problem hiding this comment.
What version of Tanka are you using? It seems like the latest version supports version numbers: https://github.com/grafana/tanka/blob/cc213234f1e103764095e99a3ea974ca71c037cc/cmd/tk/init.go#L57-L65
There was a problem hiding this comment.
You're right, thank you for pointing this out. I'd installed an old version because the link in the description pointed to an old one. I updated my tanka and also updated the link in the instructions. The command works now as it is!
rfratto
reviewed
Oct 20, 2022
ptodev
force-pushed
the
update-instructions-and-scripts
branch
from
8f72a97
to
20381cf
Compare
56quarters
approved these changes
Oct 21, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes to the instructions and the installation script.