Replace Prometheus with Mimir #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit of a hack in the interests of making this change as small as possible - jsonnet-libs/prometheus-ksonnet imports its own implementation of a Grafana setup rather than using (say) jsonnet-libs/grafana.
charleskorn
force-pushed
the
use-mimir-for-metrics
branch
from
e58a4d8
to
351d3f4
Compare
charleskorn
force-pushed
the
use-mimir-for-metrics
branch
from
351d3f4
to
0c67088
Compare
jhesketh
requested changes
Nov 4, 2022
There was a problem hiding this comment.
I haven't tried it out, but it looks pretty good to me!
My only concern is not configuring the location of the filesystem storage.
We could also consider if we want to use real object storage, but I don't think it is necessary (and would involve us deploying something like minio).
charleskorn
force-pushed
the
use-mimir-for-metrics
branch
from
5d70ae6
to
09f9254
Compare
jhesketh
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the Prometheus instance with a Mimir instance instead.
I did this as an exercise for myself, but thought it might be interesting to share. Will not be offended if this is rejected as an undesirable change :)
Outstanding work
Improvements for future PRs
jsonnet-libs/prometheus-ksonnetrather than switching to something likejsonnet-libs/grafanain the interest of keeping the PR small.