Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable exemplars on dashboard #6

Merged
merged 3 commits into from
Mar 4, 2021
Merged

Enable exemplars on dashboard #6

merged 3 commits into from
Mar 4, 2021

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Mar 3, 2021

Updated the tns-mixin dashboard to have exemplars. This requires:

  • Convert the 3 latency panels to new time series panel
  • Enable exemplars on all queries
  • Use seconds instead of ms to avoid display issue

Also regenerated the dashboard for the compose example.

joe-elliott
joe-elliott previously approved these changes Mar 3, 2021
@tomwilkie
Copy link
Contributor

This dashboard is build from the mixin - can we change the mixin to do this?

@joe-elliott joe-elliott dismissed their stale review March 3, 2021 18:59

my bad. Tom is right. if possible we need to use the mixin to generate this.

@mdisibio mdisibio changed the title Enable exemplars on dashboard in docker-compose example Enable exemplars on dashboard Mar 3, 2021
@mdisibio mdisibio merged commit b4aa8d6 into main Mar 4, 2021
@mdisibio mdisibio deleted the compose-exemplars branch March 4, 2021 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants