cmd/unused: add -add-column flag to display disk metadata value in output
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit only changes the interface and main func entry point, it currently doesn't do anything else. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
|
This PR sheds some light on the interactive UI and its ugly UI design and code, so there will be an upcoming refactor of that in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
-add-columnflag that can be indicated more than once that allows to add disk metadata in the output.For the default table view the output is the following (in brackets are those displayed only in verbose mode):
If you were to call
unused -v -add-column=foobarthe output now is:Additional
-add-columnflags will add a newMETA:$valuecolumn to the output.In the case of the interactive UI, the main disk list currently only shows the disk name. By passing this column it will add the metadata key and value to the list.