Exporter improvements #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
This is very specific and probably should be controlled via a variable, however, it works for the time being (and for disks not associated to Kubernetes PVC namespaces it will appear as an empty label). Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
dannykopping
previously approved these changes
Sep 20, 2022
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
cmd/unused-exporterin several ways, providing better readability, logging, and metrics. The most important change are in exposed metrics and their labels:unused_disks_count: How many unused disks are in this provider (gauge)unused_provider_duration_msHow long in milliseconds took to fetch this provider information (gauge)unused_provider_infoCSP information (static gauge)unused_provider_successStatic metric indicating if collecting the metrics succeeded or not (gauge, 0 or 1)All metrics have the same 2 labels,
providerandprovider_id, with the exception ofunused_disks_count: this ones contains additionally ak8s_namespacelabel.