Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor cmd/unused-exporter to make it more readable #28

Merged
merged 4 commits into from
Nov 23, 2022

Conversation

inkel
Copy link
Collaborator

@inkel inkel commented Nov 23, 2022

This PR renames some variables and makes the logic for registering the exporter and running the server easier to read.

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
This is more readable than the previous version.

Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
@inkel inkel self-assigned this Nov 23, 2022
@inkel inkel merged commit 863070b into main Nov 23, 2022
@inkel inkel deleted the exporter/refactor/server-collector branch November 23, 2022 18:07
@inkel inkel added this to the Release as OSS milestone Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant