Refactor providers creation functions #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we don't need to make the provider aware of implementation details to create a service. It should make testing and integrating easier in the long term. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
As before, this makes it easier to integrate and test, and also makes the provider unaware of AWS authentication. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Same as what we did for GCP and AWS providers. Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Signed-off-by: Leandro López (inkel) <leandro.lopez@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all the providers
NewProviderfunctions were doing more than needed by managing creating the required CSP service to access their APIs. This PR changes that to make the providers in the library package to accept the required services and nothing else. Creation of these services is a concern of the library users, not the library itself.