Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exporter test #28

Merged
merged 4 commits into from
Jul 5, 2022
Merged

Add exporter test #28

merged 4 commits into from
Jul 5, 2022

Conversation

marctc
Copy link
Contributor

@marctc marctc commented Jun 30, 2022

Added test that validates that we are exporting metrics as we defined in test_metrics.txt.
This would help in refactors in order to identify if we lost any metrics. It works using createSim
which creates a vsphere sim on the fly. This could be helpful in the future to add more tests.

This fixes #25

@marctc marctc requested a review from rlankfo June 30, 2022 13:03
@marctc
Copy link
Contributor Author

marctc commented Jun 30, 2022

For some reason drone is not able to run the tests. @rlankfo could you take a look?

@rlankfo
Copy link
Member

rlankfo commented Jun 30, 2022

For some reason drone is not able to run the tests. @rlankfo could you take a look?

It looks like the trigger is configured only to run on tags. I assume we probably want this trigger to be the same as the linter:

trigger:
  event:
    - push
    - pull_request
    - tag
  ref:
    - refs/heads/main
    - refs/pull/*/head
    - refs/tags/**

Copy link
Member

@rlankfo rlankfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! 🙌 thanks for putting this together @marctc

@rlankfo rlankfo merged commit 5ae4d77 into main Jul 5, 2022
@marctc marctc deleted the add_tests branch July 15, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for exporter
2 participants