Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update name and mo labels #31

Merged
merged 2 commits into from
Jul 28, 2022
Merged

update name and mo labels #31

merged 2 commits into from
Jul 28, 2022

Conversation

rlankfo
Copy link
Member

@rlankfo rlankfo commented Jul 28, 2022

This PR changes the "name" label to be the actual resource name, instead of the managed object name.

image

image

@rlankfo rlankfo requested a review from marctc July 28, 2022 01:55
marctc
marctc approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@marctc marctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mo a descriptive name in this context?

@rlankfo
Copy link
Member Author

rlankfo commented Jul 28, 2022

Is mo a descriptive name in this context?

Looking at the vsphere docs, I should change this to moid to be consistent.

@rlankfo rlankfo merged commit 790b5bb into main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marctc marctc marctc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rlankfo @marctc