fix discovery interval data race #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marctc
approved these changes
Aug 2, 2022
I'm re-running them -- I notice this happens once in a while and I assume it's because the simulator doesn't generate these metrics sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR read locks the endpoint's collectMux RWMutex when reading data from the endpoint object map. This prevents race conditions when discovery interval != 0 because data can no longer be read while the object maps are rewritten during discovery.
This PR also adds resources to the test's simulator VPX model, adds logging to the test, and sets a 60 second discovery interval for the exporter under test.