Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented all configs EXCEPT dfrs since it's performance counters d… #5

Merged
merged 2 commits into from
Mar 18, 2021
Merged

Implemented all configs EXCEPT dfrs since it's performance counters d… #5

merged 2 commits into from
Mar 18, 2021

Conversation

mattdurham
Copy link

…epend on config. Instead excluding it in this initial pass.

@mattdurham
Implemented all configs EXCEPT dfrs since it's performance counters d…
ad0a1b3 
…epend on config. Instead excluding it in this initial pass.
@mattdurham mattdurham requested a review from rfratto March 18, 2021 14:18
rfratto
rfratto approved these changes Mar 18, 2021
View reviewed changes
Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo exporting fields for LogicalDiskConfig

collector/logical_disk.go Outdated Show resolved Hide resolved
@mattdurham mattdurham merged commit 5789b9c into Exporter_Library Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfratto rfratto rfratto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mattdurham @rfratto