Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate color #354

Merged
merged 6 commits into from
Jun 8, 2023
Merged

Validate color #354

merged 6 commits into from
Jun 8, 2023

Conversation

ryantxu
Copy link
Member

@ryantxu ryantxu commented Jun 2, 2023

this validates legend colors before display

@ryantxu ryantxu requested a review from drew08t June 2, 2023 17:01
@CLAassistant
Copy link

CLAassistant commented Jun 2, 2023 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ nmarrs
❌ ryantxu
You have signed the CLA already but the status is still pending? Let us recheck it.

drew08t
drew08t approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@drew08t drew08t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, haven't tested it locally to confirm yet though.

@nmarrs nmarrs merged commit 439a1a5 into master Jun 8, 2023
3 of 4 checks passed
@nmarrs nmarrs deleted the validate-color branch June 8, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmarrs nmarrs nmarrs approved these changes

@drew08t drew08t drew08t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantxu @CLAassistant @nmarrs @drew08t