Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add geomap migration button to options menu #355

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

drew08t
Copy link
Contributor

@drew08t drew08t commented Jun 8, 2023

What this PR does / why we need it:
To help push for migration towards Geomap, we need to get the message out that auto migration is an option in Worldmap.

Before:
image

After:
Jun-08-2023 11-04-57

@drew08t drew08t requested review from ryantxu and nmarrs June 8, 2023 18:06
@drew08t drew08t self-assigned this Jun 8, 2023
CHANGELOG.md Show resolved Hide resolved
src/plugin.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may still want to update the plugin.json to be v1.0.4 / updated at (unless that automatically happens when the release is published, not sure)

Migrate
</button>
</p>
</div>
Copy link
Contributor

@nmarrs nmarrs Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should include a disclaimer like in graph panel that full feature parity may not exist for the time being (i.e. missing some icons, tooltip experience UX, etc.)?

Screenshot 2023-06-08 at 8 22 58 PM

In addition / alternatively, this could be a place we consider linking to the geomap github discussion to collect direct feedback on missing parity items from worldmap to geomap 🤔 (not sure on exact messaging here, but maybe something along the lines of "something missing from Geomap that you rely on in worldmap? let us know here"

Copy link
Contributor Author

@drew08t drew08t Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could probably also "advertise" some of the major new features.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree maybe we can add a sentence enticing people to switch to Geomap at the end of the of the first paragraph and then have the messaging around if something is missing to let us know in the discussion (in the section after the button)? I'm good to defer to whatever you think is best - approving PR :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this.
image

Copy link
Contributor

@nmarrs nmarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drew08t drew08t merged commit 2acf513 into master Jun 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants