Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal IAM role doesn't include permissions for the service map #108

Closed
jangaraj opened this issue Feb 23, 2022 · 5 comments · Fixed by #115
Closed

Minimal IAM role doesn't include permissions for the service map #108

jangaraj opened this issue Feb 23, 2022 · 5 comments · Fixed by #115
Assignees
Labels

Comments

@jangaraj
Copy link

Could you include permissions for the service map into minimal IAM role, please? It looks like xray:GetServiceGraph is not enough.

Thank you.

@jangaraj jangaraj added datasource/X-Ray type/bug Something isn't working labels Feb 23, 2022
@iwysiu
Copy link
Contributor

iwysiu commented Feb 24, 2022

Hi @jangaraj ! The minimal policy for x-ray can be found here: https://github.com/grafana/x-ray-datasource#iam-policies

@jangaraj
Copy link
Author

jangaraj commented Feb 24, 2022

@iwysiu Yes, but when you use that minimal policy from the doc/readme, then you will get 403 when you will try to show service map. So that is a reason why I asked to include more permissions there - it will be disappointed for the users, when they follow doc and it won't work.

@iwysiu
Copy link
Contributor

iwysiu commented Feb 24, 2022

Sorry, I misunderstood. I'll add it to the documentation. Though when I tested it, adding xray:GetServiceGraph was enough for service map. Did that not work for you?

@iwysiu iwysiu self-assigned this Feb 24, 2022
@jangaraj
Copy link
Author

xray:GetServiceGraph wasn't enough. I used lazy approach xray:Get*, but it will be fine if all permissions will be listed explicitly.

1 similar comment
@jangaraj
Copy link
Author

xray:GetServiceGraph wasn't enough. I used lazy approach xray:Get*, but it will be fine if all permissions will be listed explicitly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants