Skip to content
This repository has been archived by the owner on Dec 8, 2023. It is now read-only.

Change client to rabbitmq/amqp091-go #23

Merged
merged 2 commits into from
Jan 11, 2023
Merged

Change client to rabbitmq/amqp091-go #23

merged 2 commits into from
Jan 11, 2023

Conversation

javaducky
Copy link
Contributor

Fixes #22

Signed-off-by: Paul Balogh javaducky@gmail.com

Fixes #22

Signed-off-by: Paul Balogh <javaducky@gmail.com>
amqp.go Show resolved Hide resolved
amqp.go Show resolved Hide resolved
Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but this is IMO the smallest problem of this extension:

  1. it doesn't use the latest modules API
  2. not using event loop means that it is still panicking all the time

amqp.go Outdated Show resolved Hide resolved
Co-authored-by: Mihail Stoykov <312246+mstoykov@users.noreply.github.com>
@javaducky javaducky merged commit fad34a9 into main Jan 11, 2023
@javaducky javaducky deleted the paul/client-update branch January 11, 2023 12:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current AMQP client no longer supported
3 participants