Apply suggestions from code review

Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
grafana · Jan 11, 2024 · 04595b8 · 04595b8
1 parent d15ae71
commit 04595b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/common/element_handle.go b/common/element_handle.go
@@ -768,7 +768,7 @@ func (h *ElementHandle) ContentFrame() (*Frame, error) {
 
 	frame, found := h.frame.manager.getFrameByID(node.FrameID)
 	if !found {
-		return nil, fmt.Errorf("frame not found for id")
+		return nil, fmt.Errorf("frame not found for id %d", node.FrameID)
 	}
 
 	return frame, nil

diff --git a/common/frame_manager.go b/common/frame_manager.go
@@ -390,9 +390,8 @@ func (m *FrameManager) frameRequestedNavigation(frameID cdp.FrameID, url string,
 	return nil
 }
 
-// getFrameByID will attempt to find a frame with the given id. If one is found
-// the frame and true will be returned. If one isn't found nil and false will
-// be returned.
+// getFrameByID finds a frame with id. If found, it returns the frame and true,
+// otherwise, it returns nil and false.
 func (m *FrameManager) getFrameByID(id cdp.FrameID) (*Frame, bool) {
 	m.framesMu.RLock()
 	defer m.framesMu.RUnlock()