Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
  • Loading branch information
ankur22 and inancgumus committed Dec 15, 2023
1 parent 99009e5 commit 133793b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/remote_obj_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func TestEvalRemoteObjectParse(t *testing.T) {
name: "filled_object", eval: `{return {foo:"bar"};}`, want: map[string]any{"foo": "bar"},
},
{
name: "filled_array", eval: `{return ["foo","bar"];}`, want: []interface{}{0: "foo", 1: "bar"},
name: "filled_array", eval: `{return ["foo","bar"];}`, want: []any{0: "foo", 1: "bar"},
},
{
name: "filled_array", eval: `() => true`, want: `function()`,
Expand All @@ -161,6 +161,7 @@ func TestEvalRemoteObjectParse(t *testing.T) {
{
name: "scientific_notation", eval: "123e-5", want: 0.00123,
},
// TODO:
// {
// // This test is ignored until https://github.com/grafana/xk6-browser/issues/1132
// // has been resolved.
Expand Down

0 comments on commit 133793b

Please sign in to comment.