Update LookupBool to return two bools

Resolves: #1003 (comment)

env/env.go

@@ -87,16 +87,16 @@ func ConstLookup(k, v string) LookupFunc {
 }
 
 // LookupBool returns the result of Lookup as a bool.
-// Returns false if the key does not exist or the value
-// is not a bool.
-func LookupBool(key string) bool {
+// If the key does not exist or the value is not a valid bool, it returns false.
+// Otherwise it returns the bool value and true.
+func LookupBool(key string) (value bool, ok bool) {
 	v, ok := Lookup(key)
 	if !ok {
-		return false
+		return false, false
 	}
 	bv, err := strconv.ParseBool(v)
 	if err != nil {
-		return false
+		return false, true
 	}
-	return bv
+	return bv, true
 }

tests/frame_test.go

@@ -76,7 +76,7 @@ func TestFrameNoPanicWithEmbeddedIFrame(t *testing.T) {
 	// only surfaces when in headfull mode.
 	// Remove this skip once we have headfull mode in
 	// CI: https://github.com/grafana/xk6-browser/issues/678
-	if env.LookupBool(env.BrowserHeadless) {
+	if v, ok := env.LookupBool(env.BrowserHeadless); !ok || v {
 		t.Skip("skipped when in headless mode")
 	}
 
@@ -112,7 +112,7 @@ func TestFrameNoPanicNavigateAndClickOnPageWithIFrames(t *testing.T) {
 	// only surfaces when in headfull mode.
 	// Remove this skip once we have headfull mode in
 	// CI: https://github.com/grafana/xk6-browser/issues/678
-	if env.LookupBool(env.BrowserHeadless) {
+	if v, ok := env.LookupBool(env.BrowserHeadless); !ok || v {
 		t.Skip("skipped when in headless mode")
 	}