fixup! always use a logger no matter what

resolves: #824 (comment)
grafana · Mar 10, 2023 · 3b2de1b · 3b2de1b
1 parent 171cc76
commit 3b2de1b
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/log/logger.go b/log/logger.go
@@ -37,11 +37,10 @@ func New(logger logrus.FieldLogger, iterID string) *Logger {
 	if logger == nil {
 		ll = logrus.New()
 		ll.Warn("Logger", "no logger supplied, using default")
-	} else if l, ok := logger.(*logrus.Logger); ok {
-		ll = l
+	} else if l, ok := logger.(*logrus.Logger); !ok {
+		ll.Warn("Logger", "invalid logger type, using default")
 	} else {
-		// panic so that we know when to upgrade. see issue #818.
-		panic("logger is not a logrus.Logger")
+		ll = l
 	}
 
 	return &Logger{