Skip to content

Commit

Permalink
Update nil session log warn to debug in page attach
Browse files Browse the repository at this point in the history
Rationale:

I suggested this earlier on to detect nil sessions. But now, this
warning is outdated because when users running multiple instance/VU
tests, they will see dozens/hundreds lines of warnings.

The core reason we receive a lot of these warnings is:

We need to correctly handle the CDP messages while sending and receiving
them (the order of them).
#848
  • Loading branch information
inancgumus committed Apr 6, 2023
1 parent 8e91dd4 commit a53665c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion common/browser.go
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ func (b *Browser) onAttachedToTarget(ev *target.EventAttachedToTarget) {
}
session := b.conn.getSession(ev.SessionID)
if session == nil {
b.logger.Warnf("Browser:onAttachedToTarget",
b.logger.Debugf("Browser:onAttachedToTarget",
"session closed before attachToTarget is handled. sid:%v tid:%v",
ev.SessionID, targetPage.TargetID)
return // ignore
Expand Down

0 comments on commit a53665c

Please sign in to comment.