Skip to content

Commit

Permalink
Remove the todo
Browse files Browse the repository at this point in the history
This todo has been moved to the localPersister
  • Loading branch information
ankur22 committed Jan 31, 2024
1 parent 2747713 commit ab79ae7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion common/screenshotter.go
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ func (s *screenshotter) screenshot(
}

// Save screenshot capture to file
// TODO: we should not write to disk here but put it on some queue for async disk writes
if path != "" {
if err := s.persister.Persist(path, bytes.NewBuffer(buf)); err != nil {
return nil, fmt.Errorf("persisting screenshot: %w", err)
Expand Down

0 comments on commit ab79ae7

Please sign in to comment.