Async browser.closeContext

grafana · May 8, 2024 · d4f7e22 · d4f7e22
1 parent 81b9e7d
commit d4f7e22
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/browser/browser_mapping.go b/browser/browser_mapping.go
@@ -19,12 +19,14 @@ func mapBrowser(vu moduleVU) mapping { //nolint:funlen,cyclop
 			}
 			return mapBrowserContext(vu, b.Context()), nil
 		},
-		"closeContext": func() error {
-			b, err := vu.browser()
-			if err != nil {
-				return err
-			}
-			return b.CloseContext() //nolint:wrapcheck
+		"closeContext": func() *goja.Promise {
+			return k6ext.Promise(vu.Context(), func() (any, error) {
+				b, err := vu.browser()
+				if err != nil {
+					return nil, err
+				}
+				return nil, b.CloseContext() //nolint:wrapcheck
+			})
 		},
 		"isConnected": func() (bool, error) {
 			b, err := vu.browser()

diff --git a/tests/browser_context_test.go b/tests/browser_context_test.go
@@ -668,7 +668,7 @@ func TestK6Object(t *testing.T) {
 			// Now test with browser.newContext
 			got, err = vu.TestRT.RunOnEventLoop(`
 				const test = async function() {
-					browser.closeContext();
+					await browser.closeContext();
 					const c = await browser.newContext();
 					const p2 = c.newPage();
 					p2.goto("about:blank");