Update parseConsoleRemoteObjectValue

This updates parseConsoleRemoteObjectValue to work with parseConsoleRemoteArrayPreview which will parse an array.
grafana · Dec 15, 2023 · e522b1d · e522b1d
1 parent f0c5d58
commit e522b1d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/common/remote_object.go b/common/remote_object.go
@@ -287,6 +287,9 @@ func parseConsoleRemoteObjectValue(
 		}
 	case cdpruntime.TypeObject:
 		if op != nil {
+			if st == "array" {
+				return parseConsoleRemoteArrayPreview(logger, op)
+			}
 			return parseConsoleRemoteObjectPreview(logger, op)
 		}
 		if val == "Object" {

diff --git a/tests/remote_obj_test.go b/tests/remote_obj_test.go
@@ -30,7 +30,7 @@ func TestConsoleLogParse(t *testing.T) {
 			name: "bool", log: "true", want: "true",
 		},
 		{
-			name: "empty_array", log: "[]", want: "{}", // TODO: Improve this output
+			name: "empty_array", log: "[]", want: "[]",
 		},
 		{
 			name: "empty_object", log: "{}", want: "{}",
@@ -39,7 +39,7 @@ func TestConsoleLogParse(t *testing.T) {
 			name: "filled_object", log: `{"foo":{"bar1":"bar2"}}`, want: `{"foo":"Object"}`,
 		},
 		{
-			name: "filled_array", log: `["foo","bar"]`, want: `{"0":"foo","1":"bar"}`,
+			name: "filled_array", log: `["foo","bar"]`, want: `["foo","bar"]`,
 		},
 		{
 			name: "filled_array", log: `() => true`, want: `function()`,